Fix Bug in Flax-Speech-Encoder-Decoder Test #16041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
| ): | ||
| self.assertTrue((feature_extractor_grad_frozen == 0.0).all()) | ||
| self.assert_difference(feature_extractor_grad, feature_extractor_grad_frozen, 1e-8) | ||
| self.assert_difference(feature_extractor_grad, feature_extractor_grad_frozen, 1e-10) |
Contributor
There was a problem hiding this comment.
No need to make it that aggressive btw :-) We usually are happy with 1e-4
Contributor
Author
There was a problem hiding this comment.
Sure! I just set it in-tandem with the assert_almost_equals threshold that is run for the unfrozen gradients.
patrickvonplaten
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in a Flax-Speech-Encoder-Decoder test that was failing after push (https://github.com/huggingface/transformers/runs/5493110105?check_suite_focus=true). Specifically, it amends the
test_freeze_feature_encodertest to omit the randomdecoder_attention_maskfrom the input arguments of the speech-encoder-decoder model. This randomdecoder_attention_maskwas resulting innanvalues on the output logits of theFlaxWav2Vec2BartModelTest. Removing it as an input results in real valued output logits, and the test of concern passes following this change. The behaviour of the FlaxBartForCausalLM model to outputnanvalues given a randomdecoder_attention_maskhas been noted.